Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gaphor: init at 2.6.5 #142708

Merged
merged 3 commits into from
Nov 13, 2021
Merged

gaphor: init at 2.6.5 #142708

merged 3 commits into from
Nov 13, 2021

Conversation

WolfangAukang
Copy link
Contributor

Motivation for this change

#142459

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@WolfangAukang WolfangAukang mentioned this pull request Oct 24, 2021
Closed
@WolfangAukang WolfangAukang marked this pull request as draft October 24, 2021 03:08
@WolfangAukang
Copy link
Contributor Author

WolfangAukang commented Oct 24, 2021 •
edited

Python packages are not properly built (missing pythonImportsCheck), so I'm going to set it as a draft for now.

@WolfangAukang WolfangAukang marked this pull request as ready for review October 24, 2021 03:27
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/616

@WolfangAukang
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 24, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 24, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

fabianhjr
fabianhjr approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, built on x86_64 nixos but didn't run/test binaries.

3 packages built:
gaphor python38Packages.gaphas python38Packages.generic

@fabianhjr
Copy link
Member

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau October 30, 2021 01:09
timokau
timokau requested changes Oct 30, 2021
View reviewed changes
pkgs/tools/misc/gaphor/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gaphor/default.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 requested changes Oct 31, 2021
View reviewed changes
pkgs/development/python-modules/generic/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/generic/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/gaphas/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/gaphas/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/gaphas/default.nix Outdated Show resolved Hide resolved
@fabianhjr fabianhjr requested review from fabianhjr and removed request for fabianhjr October 31, 2021 22:09
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 4, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

timokau
timokau requested changes Nov 6, 2021
View reviewed changes
pkgs/tools/misc/gaphor/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/gaphor/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer reviewed Nov 8, 2021
View reviewed changes
pkgs/development/python-modules/generic/default.nix
}:

buildPythonPackage rec {
pname = "generic";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing against your PR, just the package name -_-

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikr, I thought the same. If you have any recommendations, I would be happy to change it, because it is too "generic" :)

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 11, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 142708 run on x86_64-linux 1

5 packages built:
  • gaphor
  • python38Packages.gaphas
  • python38Packages.generic
  • python39Packages.gaphas
  • python39Packages.generic

@SuperSandro2000 SuperSandro2000 merged commit 5db4c4e into NixOS:master Nov 13, 2021
@WolfangAukang WolfangAukang deleted the gaphor branch November 15, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@fabianhjr fabianhjr Awaiting requested review from fabianhjr

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@jonringer jonringer Awaiting requested review from jonringer

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@WolfangAukang @nixos-discourse @fabianhjr @SuperSandro2000 @timokau @jonringer